Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-20467

PHP notices on contact search for ACL'd user

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.7.19
          • Fix Version/s: 4.7.19
          • Component/s: Core CiviCRM
          • Labels:
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Contributed Code
          • Verified?:
            No

            Description

            Logged in as user with restricted Civi permissions: just "access CiviCRM" + ACL view for one group, on the following pages:

            /civicrm/contact/search?reset=1 + search results
            /civicrm/contact/search/advanced?reset=1 + search results
            /civicrm/contact/search/custom?csid=15&reset=1
            /civicrm/contact/search/builder?reset=1
            /civicrm/contact/view

            I get this PHP notice:

            Notice: Undefined variable: values in CRM_Contact_BAO_Contact::checkUserMenuPermissions() (line 3202 of .../sites/all/modules/civicrm/CRM/Contact/BAO/Contact.php).

            Here's the offending line:

                    if (in_array($values['ref'], $aclPermissionedTasks) &&

            $values is not defined in this function. Appears due to this commit:

            https://github.com/civicrm/civicrm-core/commit/9309f5c6353b765541f2e09f072b9538441895d8
            https://github.com/civicrm/civicrm-core/pull/10046
            CRM-20332 Modified function to prevent tampering with original menu

              Attachments

                Issue Links

                supplements

                Improvement - An improvement or enhancement to an existing feature or task. CRM-20332 Refactor summaryActions hook to allow user-defined actions in third column

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Done/Fixed
                links to

                Web Link PR: civicrm-core#10243: CRM-20467: PHP notices on contact search for ACL'd user

                Web Link PR: civicrm-core#10243: CRM-20467: PHP notices on contact search for ACL'd user

                  Activity

                    People

                    • Assignee:
                      davej Dave Jenkins
                      Reporter:
                      davej Dave Jenkins
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: