Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-20687

Issue numbers used as variables

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.19
    • Fix Version/s: 4.7.23
    • Component/s: Core CiviCRM
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Needs Funding
    • Verified?:
      No

      Description

      Using issue numbers as variables is not very self-explanatory and needs research or prior understanding just to understand the code. 

      In the Civi/API/Subscriber/ChainSubscriber.php one of the variables is named after an issue and I think it would be more readable if we gave it a meaningful name that doesn't require more research.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              michael Michael Devery
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Remaining Estimate - 30 minutes
                30m
                Logged:
                Time Spent - Not Specified
                Not Specified