Details
-
Type:
Improvement
-
Status: Open
-
Priority:
Trivial
-
Resolution: Unresolved
-
Affects Version/s: 4.7.19
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Versioning Impact:Patch (backwards-compatible bug fixes)
-
Documentation Required?:None
-
Funding Source:Needs Funding
-
Verified?:No
Description
civicrm_api3_get_BAO and _civicrm_api3_get_DAO are both prefixed with _civi_crm_api3 and are located in the api3/utils directory. I think these functions could be useful in other cases so I would like to move them to a separate class.
Since I don't think these functions will result in any database calls it should be fine to keep them static. After moving them to a separate class it should be easy to write some quick unit tests for them.
For now I would deprecate the original functions and replace the content with calls to the new class method.