Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21218

Improve component statics flushing

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.25
    • Fix Version/s: 4.7.30
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      I'm getting test failures on unit tests on extensions due to the way statics are being flushed. 

       

      Currently setting.create calls Component::flushComponents BEFORE saving the setting. 

       

      FlushComponents does not just flush them - it also tries to reload them & I'm finding this unreliable.

       

      I propose that it should be changed to do what it says - flush only - and leave the reload for later. With that change my unit test starts passing again

       

      (I'm unsure why I started seeing this error but I suspect it was a problem 'unmasked' by another change)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: