Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21249

Google Geocode limit breaks Jenkins test

          Details

          • Type: Patch
          • Status: Done/Fixed
          • Priority: Minor
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.7.24
          • Fix Version/s: 4.7.28
          • Component/s: Test suite
          • Labels:
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Contributed Code
          • Verified?:
            No
          • Overview:
            Hide
            Running the phpunit GeocodeTest sometimes returns an error that the query limit on Google is reached, and the test fails on Jenkins.

            Examples:
            https://test.civicrm.org/job/CiviCRM-Core-PR/17391/
            https://test.civicrm.org/job/CiviCRM-Core-PR/17415/
            Show
            Running the phpunit GeocodeTest sometimes returns an error that the query limit on Google is reached, and the test fails on Jenkins. Examples: https://test.civicrm.org/job/CiviCRM-Core-PR/17391/ https://test.civicrm.org/job/CiviCRM-Core-PR/17415/
          • How it works currently:
            Hide
            env CIVICRM_UF=UnitTests php `which phpunit4` tests/phpunit/CRM/Utils/GeocodeTest.php
            Sometimes:
            ...
            There were 2 failures:
            1) CRM_Utils_GeocodeTest::testStateProvinceFormat
            Failed asserting that false is true.
            ...

            2) CRM_Utils_GeocodeTest::testGeocodeMethodOff
            approx-equals: expected=[38.890] actual=[0.000] tolerance=[1.000]
            Failed asserting that false is true.
            ...
            Show
            env CIVICRM_UF=UnitTests php `which phpunit4` tests/phpunit/CRM/Utils/GeocodeTest.php Sometimes: ... There were 2 failures: 1) CRM_Utils_GeocodeTest::testStateProvinceFormat Failed asserting that false is true. ... 2) CRM_Utils_GeocodeTest::testGeocodeMethodOff approx-equals: expected=[38.890] actual=[0.000] tolerance=[1.000] Failed asserting that false is true. ...
          • How it should work:
            Hide
            env CIVICRM_UF=UnitTests php `which phpunit4` -v tests/phpunit/CRM/Utils/GeocodeTest.php
            Sometimes:
            ...
            There were 2 incomplete test:
            1) CRM_Utils_GeocodeTest::testStateProvinceFormat
            geo_code_error: OVER_QUERY_LIMIT
            ...

            2) CRM_Utils_GeocodeTest::testGeocodeMethodOff
            Job.geocode error_message: A fatal error was triggered: Aborting batch geocoding. Hit the over query limit on geocoder.
            ...
            Show
            env CIVICRM_UF=UnitTests php `which phpunit4` -v tests/phpunit/CRM/Utils/GeocodeTest.php Sometimes: ... There were 2 incomplete test: 1) CRM_Utils_GeocodeTest::testStateProvinceFormat geo_code_error: OVER_QUERY_LIMIT ... 2) CRM_Utils_GeocodeTest::testGeocodeMethodOff Job.geocode error_message: A fatal error was triggered: Aborting batch geocoding. Hit the over query limit on geocoder. ...
          • Acceptance Criteria:
            Hitting the Google Geocode limit gives a warning instead of an error on Jenkins.

            Attachments

              Activity

                People

                • Assignee:
                  seamuslee Seamus Lee
                  Reporter:
                  hollandopensource.nl Daniël van Vuuren
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 3 hours
                    3h
                    Remaining:
                    Remaining Estimate - 3 hours
                    3h
                    Logged:
                    Time Spent - Not Specified
                    Not Specified