[CRM-21259] Deleting membership types do not remove price field values from online membership forms - CiviCRM Issue Tracker

Details

Versioning Impact:
Patch (backwards-compatible bug fixes)
Documentation Required?:
User and Admin Doc
Funding Source:
Contributed Code
Verified?:
No
How it works currently:
Selecting the deleted membership type will create a successful contribution, but no membership is created.
How it should work:
The membership type should be removed from the available price field options.
Acceptance Criteria:

Hide
Remove records from price_field_value table where membership_type_id IS NULL and price field is associated with a membership for a data cleanup.

Deleting a membership type should perform an ON DELETE CASCADE instead of ON DELETE SET NULL on the price_field_value table

Show
Remove records from price_field_value table where membership_type_id IS NULL and price field is associated with a membership for a data cleanup. Deleting a membership type should perform an ON DELETE CASCADE instead of ON DELETE SET NULL on the price_field_value table

Steps to replicate.

Create an online membership form by enabling membership section and selecting the various membership types to be used.
Now delete one of the membership types from the backend.
The membership type is still displayed on the form.

Selecting this membership type will create a successful contribution, but no membership is created.