CRM-21291 Confirm this code is not used & remove

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.25
    • Fix Version/s: 4.7.28
    • Component/s: Dedupe
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      I am fairly sure this code in CRM/Contact/Page/DedupeFind.tpl is non-functional

       

      {if $cid}
       <table style="width: 45%; float: left; margin: 10px;">
       <tr class="columnheader"><th colspan="2">{ts 1=$main_contacts[$cid]}Merge %1 with{/ts}</th></tr>
       {foreach from=$dupe_contacts[$cid] item=dupe_name key=dupe_id}
       {if $dupe_name}
       {capture assign=link}<a href="{crmURL p='civicrm/contact/view' q="reset=1&cid=$dupe_id"}">{$dupe_name}</a>{/capture}
       {capture assign=merge}<a href="{crmURL p='civicrm/contact/merge' q="reset=1&cid=$cid&oid=$dupe_id"}">{ts}merge{/ts}</a>{/capture}
       <tr class="{cycle values="odd-row,even-row"}">
       <td>{$link}</td>
       <td style="text-align: right">{$merge}</td>
       <td style="text-align: right"><a class='crm-notDuplicate' href="#" title={ts}not a duplicate{/ts} onClick="processDupes( {$main.srcID}, {$main.dstID}, 'dupe-nondupe' );return false;">{ts}not a duplicate{/ts}</a></td>
       </tr>
       {/if}
       {/foreach}
       </table>
       {/if}

       

      Adding &cid=202 to the url briefly flashes up a broken version of this - e.g

      civicrm/contact/dedupefind?reset=1&action=update&rgid=4&limit=5000&cid=203

       

      I can't figure out what the purpose of it would otherwise be

        Attachments

          Activity

          [CRM-21291] Confirm this code is not used & remove
          Eileen McNaughton added a comment -
          Jamie McClelland added a comment -

          Wow, I feel like an archaeologist.

          The snippet iterates over the array $dupe_contacts - but I can't find where that array is set and can't get anything to happen by adding cid= to the URL other than the words "merge with" and nothing else.

          I am in favor of pulling..

           

          Coleman Watts added a comment -

          Eileen can you do a PR?

            People

            • Assignee:
              Unassigned
              Reporter:
              Eileen McNaughton

              Dates

              • Created:
                Updated:
                Resolved: