Details
-
Type:
Improvement
-
Status: Open
-
Priority:
Trivial
-
Resolution: Unresolved
-
Affects Version/s: 4.7.25
-
Fix Version/s: None
-
Component/s: Dedupe
-
Labels:
-
Versioning Impact:Patch (backwards-compatible bug fixes)
-
Documentation Required?:None
-
Funding Source:Needs Funding
-
Verified?:No
Description
Wow this is even crazier than CR-21291 Jamie McClelland John Kingsnorth - I kept wondering why we seemed to be rendering contacts in the page & then again by ajax so I tried a wee test & so far I can't see any downside to removing this whole chunk of code!
```
— a/CRM/Contact/Page/DedupeFind.php
+++ b/CRM/Contact/Page/DedupeFind.php
@@ -154,24 +154,7 @@ class CRM_Contact_Page_DedupeFind extends CRM_Core_Page_Basic {
CRM_Dedupe_Merger::resetMergeStats($cacheKeyString);
}
- $this->_mainContacts = CRM_Dedupe_Merger::getDuplicatePairs($rgid, $gid, !$isConflictMode, 0, $isConflictMode, '', $isConflictMode, $criteria, TRUE);
- - if (empty($this->_mainContacts)) {
- if ($isConflictMode) {
- // if the current screen was intended to list only selected contacts, move back to full dupe list
- $urlQry['action'] = 'update';
- unset($urlQry['snippet']);
- CRM_Utils_System::redirect(CRM_Utils_System::url(CRM_Utils_System::currentPath(), $urlQry));
- }
- $ruleGroupName = civicrm_api3('RuleGroup', 'getvalue', array('id' => $rgid, 'return' => 'name'));
- CRM_Core_Session::singleton()->setStatus(ts('No possible duplicates were found using %1 rule.', array(1 => $ruleGroupName)), ts('None Found'), 'info');
- $url = CRM_Utils_System::url('civicrm/contact/deduperules', 'reset=1');
- if ($context == 'search') {
- $url = CRM_Core_Session::singleton()->readUserContext();
- }
- CRM_Utils_System::redirect($url);
- }
- else {
+ if(1) {
```
Will put up a pr for testing - will do it properly if agreed - don't want to confuse things with whitespace change yet