[CRM-21391] Refactor tasks to use a base class - CiviCRM Issue Tracker

Details

Type: Improvement
Status: Done/Fixed
Priority: Trivial
Resolution: Fixed/Completed
Affects Version/s: 4.7.25
Fix Version/s: 5.0.0
Component/s: None
Labels:
- PatchSubmitted

Versioning Impact:
Patch (backwards-compatible bug fixes)
Documentation Required?:
None
Funding Source:
Needs Funding
Verified?:
No

Description

Refactor all the component tasks so they are extend a new base class CRM_Core_Task.

There were a number of issues with the "Advanced Search" when switching between component types where the task list would be populated with the wrong list of tasks, but the keys would trigger an action on the selected component and an unexpected action may occur.

Also there seemed to be a bug with saving group_type where mailing_list was always being checked.

This cleans up the code and uses shared code where possible.

Further refactoring would be possible, also some tasks actually work in all contexts (eg. create/update smart group) and we could extend the lists to share these elements too.