Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21412

Do not give fatal error on report when no fields selected

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.27
    • Fix Version/s: 4.7.30
    • Component/s: CiviReport
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      This is a trivial fix to ensure that when a report that inherits the main 'select' function is rendered with no fields selected there is no hard error - by adding SELECT 1 instead of leaving the select clause missing. 

      This is an upstream of a fix that has been in extended reports for some time. I don't know of an obvious way to replicate it but I feel there is no risk of harm here (reports that do weird things manage their own selects) and it helps people writing custom reports.

        Attachments

          Activity

            People

            • Assignee:
              eileen Eileen McNaughton
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: