Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21435

Some Reports are calling both buildACLClause and buildPermissionClause, creating artefacts in the results

          Details

          • Type: Bug
          • Status: Open
          • Priority: Minor
          • Resolution: Unresolved
          • Affects Version/s: 4.7.27
          • Fix Version/s: None
          • Component/s: CiviReport
          • Labels:
            None
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Needs Funding
          • Verified?:
            No

            Description

            The former function creates a join that doesn't seem to be used properly, and doesn't care about the ACL operation - so if multiple ACL operations are available between a contact and user, it duplicates rows.

            The latter function gets a clause from the Contact BAO which completely supercedes the former.

            I have a working patch that fixes the Top Donors report now, it looks like just removing buildACLClause from reports that use the base buildQuery() function should work - but these will probably need test cases built.

              Attachments

                Activity

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    agileware Agileware
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated: