Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21458

(CIVICRM-742) HTML_QuickForm_hierselect doesn't handle JS escaping properly

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.27
    • Fix Version/s: 4.7.30
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Needs Funding
    • Verified?:
      No

      Description

      This causing things using the hierselect element to crash Javascript if e.g. there's a backslash at the end of one of the option names.

      Steps to demonstrate:

      1. Create an Event titled "Look what happens when I finish in a \"
      2. Attempt to add a new Schedule Reminder
      3. Expected result: Schedule reminder modal is opened with full javascript
      4. Actual result: Schedule reminder modal opens, and can be closed, but:
        • no javascript features are loaded.
        • "Unterminated string literal" error in jQuery eval functions is recorded in the console

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              agileware Agileware
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: