Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21685

Disable relationships on contact soft-delete

    Details

    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Needs Funding
    • Verified?:
      Yes
    • How it works currently:
      When a contact with active relationships is soft-deleted, no change is made to those relationships.
    • How it should work:
      When a contact with active relationships is soft-deleted, all of those relationships are set to inactive.
    • Acceptance Criteria:
      Hide
      Unit test succeeds for: When a contact with one active relationship is soft-deleted, that relationships is set to inactive.

      Manual test succeeds for: When a contact with two active relationships is soft-deleted, both of those relationships are set to inactive.
      Show
      Unit test succeeds for: When a contact with one active relationship is soft-deleted, that relationships is set to inactive. Manual test succeeds for: When a contact with two active relationships is soft-deleted, both of those relationships are set to inactive.

      Description

      As part of analysis of problems with on-behalf-of contributions coming in for deleted contacts (CRM-20287), people found that soft-deletion of a contact did not set all of its relationships to inactive. While this led to further issues regarding the contribution, this issue is about fixing the relationship status.

      There are two options for how we do this.

      1) Just set the relationship to disabled.

      2) Set an end date for the relationship. If the end date is before today, then the relationship is set inactive as well.

      I recommend 1) as 2) is not a common or at least universal workflow in organizations I know, and it implies more about the relationship than the mere soft deletion of one of its contacts requires. If the contact is undeleted later, in either case manual reactivation of the relationship is possible. 

      S

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                erikhommel Erik Hommel
                Reporter:
                joemurray Joe Murray
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: