Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21705

When making a credit card payment, the billing address is created twice

    Details

    • Type: Improvement
    • Status: Won't Do
    • Priority: Trivial
    • Resolution: Won't Do
    • Affects Version/s: 4.7.29
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Needs Funding
    • Verified?:
      No

      Description

      Furthermore, one of the addresses is created without a contact_id so it is effectively orphaned.

      Here are the tracebacks from the Core_BAO_Address->add:

      This one has the contact id properly set:

      CRM_Core_BAO_Address->add
      CRM_Core_BAO_Address->create
      CRM_Core_BAO_Location->create
      CRM_Contact_BAO_Contact->create
      CRM_Contact_BAO_Contact->createProfileContact
      CRM_Contribute_Form_AbstractEditPayment->processBillingAddress
      CRM_Contribute_Form_Contribution->processCreditCard
      

      This one does not:

      CRM_Core_BAO_Address->add
      CRM_Contribute_BAO_Contribution->createAddress
      CRM_Contribute_Form_Contribution_Confirm->processFormContribution
      CRM_Contribute_Form_Contribution->processCreditCard
      CRM_Contribute_Form_Contribution->submit
      CRM_Contribute_Form_Contribution->testSubmit
      CRM_Contribute_Form_ContributionTest->testOneAddress
      

      It looks like the processCreditCard function is where both of these start.

        Attachments

          Activity

            People

            • Assignee:
              jamie Jamie McClelland
              Reporter:
              jamie Jamie McClelland
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: