Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21729

Exclude (non-lintable) vendor test cases from deply

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.7.31
          • Fix Version/s: 4.7.31
          • Component/s: Core CiviCRM
          • Labels:
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Contributed Code
          • Verified?:
            No

            Description

            One of our composer packages (phpquery) contains test files that do not pass phplint. I think it best practice to exclude these from our deployment as they undermine the (good) practice of others linting our code & tests are better off prod. I did do an upstream PR

            https://github.com/electrolinux/phpquery/pull/13

             

            However, it seems we have a way to exclude in distmaker & the directories in question are very generic

              Attachments

                Activity

                  People

                  • Assignee:
                    eileen Eileen McNaughton
                    Reporter:
                    eileen Eileen McNaughton
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: