CRM-3432 Move generic payment processor notify functions into baseIPN

          Details

          • Type: Improvement
          • Status: Done/Fixed
          • Priority: Minor
          • Resolution: Won't Fix
          • Affects Version/s: 2.2.0
          • Fix Version/s: 2.2.0
          • Component/s: CiviContribute, CiviGrant
          • Labels:
            None

            Description

            In order to better allow people to develop payment processors move the newOrderNotify and getContext functions into baseIPN. The version of the functions in the paymentexpress module is generic but probably needs a bit more in it whereas the google one is a bit too google - specific - i.e. passes the xml root through rather than the array of variables.

              Attachments

                Activity

                [CRM-3432] Move generic payment processor notify functions into baseIPN
                Donald A. Lobo added a comment -


                I looked at the code for both and not sure if it is worth the hassle to centralize it since different PP's send information in different ways and there are a few things specific to each PP. Considering that most PP's are going to be copied and edited (and also maintained by non-civicrm folks) i think keeping as is might be a better solution (for now). I'd probably want to wait for a few more of the same model before generalizing it

                Michał Mach added a comment -

                Mass closing "In verification" issues which have resolutions different than "Fixed/Resolved" - they don't show up in verification filters anyway.

                  People

                  • Assignee:
                    Michał Mach
                    Reporter:
                    Eileen McNaughton

                    Dates

                    • Created:
                      Updated:
                      Resolved: