Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-4971

WYSIWYG Editor windows : Height and Width Attributes are not being set properly

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      The problem is different for fckEditor vs. tinyMCE...

      fckEditor: a fixed value is defined for Height and Width in packages/HTML/QuickForm/fckeditor.php regardless of the fields attributes (Height=400px, Width=95%). I went ahead and added some logic to make the height smaller IF the rows attribute was <= 4. This is probably sufficient since it basically prevents us from giving a huge editor window for places that we've determined in the xml/schema don't need it. (no change required - just review changes in this file lines 80-83

      tinyMCE: we also define a Height and Width for this editor in packages/HTML/QuickForm/tinymce.php - but as far as I can tell these values are never passed to the editor iFrame. This means we are always presented a window that uses tinyMCE defaults (containing table has width: 658px; height: 186px; and edit window has width: 100%; height: 119px. This is too small for CiviMail Mail message (HTML) and similar forms. If we can pass in our defaults (height=400px width=95%) for this editor, and then override the height only for attributes['rows'] <= 4 (as I've done for fckEditor) - that would be sufficient for now. (You will need to make sure that you pass the 95% width for both the containing table and the iFrame - or you'll wind up with an edit window that's 95% or 658px rather than 95% of available form width.)

        Attachments

          Activity

            People

            • Assignee:
              amit Amiteshwar Prasad
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: