Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-5187

create-pot-files.sh misses strings in .hlp files, generates outdated headers in .pot files

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0.3
    • Labels:
      None

      Description

      I ran the bin/create-pot-files.sh script to begin with my own translation. It gave me several files to work with, one of which was civicrm-helpfiles.pot .

      I wanted to make changes to the strings in templates/CRM/Contact/Form/Domain.hlp file but the civicrm-helpfiles.pot file did not contain all the strings present in it. In fact, it contained only 2 of 5 strings enclosed in

      {ts} in that file. I am guessing that this is happening across other .hlp files too.

      All those lines skipped did seem to contain unacceptable characters, but I am not sure about that. Because the bin/create-pot-files.sh script throws a lot of warnings about "Invalid marker content" in ts() functions all over the code, but none about {ts}

      or this location.

      Secondly, line 19 of bin/create-pot-files.sh still writes "CiviCRM 2.2" to the .pot files' headers. Maybe it should be set to "CiviCRM 3.0" in this release.

        Attachments

        1. CRM-5187_dhruvahuja_2.patch
          0.5 kB
          Dhruv Ahuja
        2. CRM-5187_dhruvahuja.patch
          0.5 kB
          Dhruv Ahuja

          Activity

            People

            • Assignee:
              shot Piotr Szotkowski
              Reporter:
              dhruvahuja Dhruv Ahuja
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: