Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Minor
-
Resolution: Fixed/Completed
-
Affects Version/s: 2.2.9, 3.0
-
Fix Version/s: 3.1
-
Component/s: CiviContribute
-
Labels:None
Description
In Civicontribute, if you have a contribution page set up with "Separate Membership Payment" the button on the confirm page always reads "continue" and never "Make Contribution".
This is a particular problem because the text just above the button reads "Your contribution will not be completed until you click the ***Make Contribution*** button. Please click the button one time only."
Since no "Make Contribution" button every appears, this is a bit confusing.
The cause seems to be in confirm.php around line 260:
if ( $this->_contributeMode == 'notify' || !$this->_values['is_monetary'] ||
$this->_amount <= 0.0 || $this->_params['is_pay_later']
| $this->_separateMembershipPayment )
{
$contribButton = ts('Continue >>');
} else {
$contribButton = ts('Make Contribution');
} I created this updated version which fixes my particular use case but I'm still not sure that it fixes the general case (I'm not totally clear on what the logic of the general case should be!). if ( $this->_contributeMode == 'notify' || !$this->_values['is_monetary'] || ( $this->_amount <= 0.0 && ! $this->_separateMembershipPayment ) || $this->_params['is_pay_later'] ) { $contribButton = ts('Continue >>'); } else { $contribButton = ts('Make Contribution'); } |
|---|
In general it probably should list "Make Contribution" any time there is an amount of money that is charged when the button is pressed. in the case of separate membership payments, that is if the person has selected a membership option with an amount attached OR entered an additional contribution amount.
