CRM-5384 Stack trace when mail processor has an error includes passwords in plain text

          Details

          • Type: Improvement
          • Status: Done/Fixed
          • Priority: Minor
          • Resolution: Won't Fix
          • Affects Version/s: 3.0.2
          • Fix Version/s: 4.3.0
          • Component/s: CiviMail
          • Labels:
            None

            Description

            When the mail processor has some kind of error and prints a stack trace, the password it was using to log in is output as part of the trace in plain text, e.g.

            ...
            MailStore.php(65): CRM_Mailing_MailStore_Pop3->__construct('servername', 'username', 'password', true)
            ...

              Attachments

                Activity

                [CRM-5384] Stack trace when mail processor has an error includes passwords in plain text
                Donald A. Lobo added a comment -

                did u have backtrace turned on?

                was it an uncaught exception?

                Dave D added a comment -

                Backtrace is not turned on.
                Yes it's an uncaught exception from ezc.

                One way to reproduce is to run bin/EmailProcessor.php to retrieve messages from a gmail IMAP account (CRM-5431).

                Dave D added a comment -

                Some thoughts from the sprint:

                Maintain a list of functions whose parameters could potentially contain sensitive info and in civi's error handling routines where the stack trace is output do string replace on the lines that contain those function names.

                The main issue in this case is that it is an automated process running against the organization's user's own inboxes, as opposed to a system mailbox where it would be ok for a sysadmin to see the passwords. So if there was another way to get the emails with headers intact that would be another approach.

                Donald A. Lobo added a comment -

                These 448 issues have not been worked on for the past 18 months.

                Doing a bulk close of old issues to make the issue queue more manageable. We should do this on a periodic basis.

                  People

                  • Assignee:
                    Donald A. Lobo
                    Reporter:
                    Dave D

                    Dates

                    • Created:
                      Updated:
                      Resolved: