Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-5448

concurrent contact merge / de-dupe operations fail silently

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.0, 3.0.1, 3.0.2
    • Fix Version/s: None
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      Steps to reproduce:
      Step 01) on PAGE 1: obtain a contact merge and de-dupe screen presenting a list of merges
      Step 02) on PAGE 1: submit REQUEST 1: click on one "merge" link (opening in a new tab: PAGE 2) to view the side-by-side comparison of the two contacts to merge
      Step 03) on PAGE 2: fill out the check boxes appropriately
      Step 04) on PAGE 2: submit REQUEST 2: click the merge button (...also, get ready for the next step, because you'll need to perform it quickly!)
      Step 05) on PAGE 1: submit REQUEST 3: click another "merge" link (opening in a new tab: PAGE 3)
      Step 06) on PAGE 2 and PAGE 3: (observe that they are loading simultaneously)
      Step 07) on PAGE 2: when it completes, observe that is presents the user with a message indicating that the merge process from REQUEST 2 has completed successfully
      Step 08) on PAGE 1: submit REQUEST 4 as the exact same request as REQUEST 1 (click on the same link again) (opening in a new tab: PAGE 4)
      Step 09) on PAGE 4: *EXPECT* that the page indicates that the merge has indeed completed
      Step 10) on PAGE 4: *OBSERVE* that the page looks exactly as it did in Step 03 – the merge didn't actually happen due to the submission of REQUEST 3

      Note:
      In order to observe this bug, you'll need to make sure that you submit REQUEST 3 before receiving the response from REQUEST 2

      Available workaround:

      • If you submit REQUEST 3 without the "reset=1" parameter, the the merge resulting from REQUEST 2 completes as expected.

      Possible fixes:

      • Perhaps CiviCRM should generate the merge URLs without the reset=1 parameter – I have not yet run in to a case where it seems necessary.
      • At the very least, it would be nice if, in Step 07, CiviCRM presented the user with an error message so that the user knows to re-do the merge

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              seanmadsen Sean Madsen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: