Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 3.2.3
-
Fix Version/s: 3.3.alpha
-
Component/s: Test suite
-
Labels:None
Description
When trying to run phpunit testson JIRA I hit 2 issues -1 is the class name in the unittest suite & the second appears to be an error in the civicrm core code (exactly the sort of thing the test suite should detect!)
(1:06:55 PM) eileen: dlobo - I just tried to run the tests through & hit a conflict in class names - this line class CRM_Contact_BAO_GroupContactTest extends CiviUnitTestCase is in two files
(1:07:52 PM) eileen: phpunit/CRM_Contact_BAO_GroupContact & phpunit/CRM_Contact_BAO_GroupContactTest - should it be changed in GroupContact?
(1:11:20 PM) dlobo: eileen: its not under phpunit
(1:11:26 PM) dlobo: do u mean phpunit/api/v2
(1:11:44 PM) eileen: yes I do
(1:11:52 PM) dlobo: petednz: no, since we need to support standalone, we dont use the qfKey for profile forms, and hence it has that issue
(1:12:01 PM) eileen: If I rename that class it works but I get this error
(1:12:02 PM) eileen: Fatal error: Call to undefined method CRM_Contact_BAO_GroupContact::getTableName() in C:\xampp\htdocs\civicrm-Trunk\CRM\ACL\BAO\ACL.php
(1:12:02 PM) eileen: on line 500
(1:12:14 PM) eileen: which seems like a legitimate bug
(1:13:16 PM) eileen: in that the 'real' code really doesn't have CRM_Contact_BAO_GroupContact::getTableName() in it
(1:13:16 PM) eileen: on line 500
(1:20:51 PM) dlobo: not sure why michal created that ile
(1:20:55 PM) dlobo: i'll hae to chec
(1:21:02 PM) dlobo: i'll have to check with him
(1:21:06 PM) dlobo: but does seem like a bug
(1:22:08 PM) awjr is now known as awjr-away
(1:27:10 PM) eileen: dlobo - do you want me to log for him to check?
(1:27:22 PM) eileen: if we have JIRA
(1:29:22 PM) colinsagan left the room (quit: Quit: colinsagan).