Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-7038

New Pledge Frequency Units do not localize in dropdown box.

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.2.5
    • Component/s: CiviContribute
    • Labels:
      None

      Description

      The dropdown values for the frequency units for new pledges do not localize correctly.

      It appears that in CRM/Pledge/Page/Pledge.php about line 368, $label should be used instead of $key to form the $freqUnitsDisplay array.

      Thus it can be fixed by changing line 367 from:

      $freqUnitsDisplay[$val] = ts( '%1(s)', array( 1 => $val ) );

      To:

      $freqUnitsDisplay[$val] = ts( '%1(s)', array( 1 => $label) );

      The ts() function in this line is only translating the plural ending (s) but is not translating the frequency unit itself; for this reason the localized frequency unit should be used.

        Attachments

          Activity

            People

            • Assignee:
              shot Piotr Szotkowski
              Reporter:
              leonardwestermeyer Leonard Westermeyer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Remaining Estimate - 30 minutes
                30m
                Logged:
                Time Spent - Not Specified
                Not Specified