Details

      Description

      I'm going to create sub-tasks of this one for each file that I've modified to avoid "variable not found", "Undefined property", and "Undefined index" errors.

      See CRM-5802 for background and motivation, but ignore the patch therein as I'm starting over from scratch.

      The following issues should be either moved or re-created as sub-tasks of this task:

      When I've been able to run CiviCRM through its paces with no spurious warnings in the logs, I'll create a combined patch and attach it to this issue.

        Attachments

        1.
        Undefined index: help_post in drupal/modules/views/civicrm_views.inc on line 5117 Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        2.
        Undefined variable: workflowClause in CRM/Mailing/BAO/Job.php on line 91. Trivial Done/Fixed Donald A. Lobo  
         
        3.
        Undefined index: searchRows in Contact/Page/View/Relationship.tpl on line 81 Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        4.
        Undefined property: CRM_Core_Config::$defaultSymbol in common/jsortable.tpl on line 183 Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        5.
        Undefined index: isForm in common/snippet.tpl on line 45 Trivial Done/Fixed Donald A. Lobo  
         
        6.
        Undefined index: isAddressCustomPresent in Contact/Page/View/Summary.tpl on line 550. Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        7.
        Undefined index: demographics_viewCustomData in Contact/Page/View/Demographics.tpl on line 41. Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        8.
        CRM/Contact/BAO/Contact.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 10 minutes
        Remaining Estimate - 10 minutes
         
        9.
        CRM/Contact/Form/Contact.php Trivial Done/Fixed Donald A. Lobo  
         
        10.
        CRM/Contact/Form/Search.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 15 minutes
        Remaining Estimate - 15 minutes
         
        11.
        CRM/Contact/Form/Task/AddToGroup.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 10 minutes
        Remaining Estimate - 10 minutes
         
        12.
        CRM/Core/BAO/CustomGroup.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 10 minutes
        Remaining Estimate - 10 minutes
         
        13.
        CRM/Core/DAO.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        14.
        CRM/Mailing/BAO/Job.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 20 minutes
        Remaining Estimate - 20 minutes
         
        15.
        CRM/Mailing/BAO/Mailing.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        16.
        CRM/Mailing/Form/Schedule.php Trivial Done/Fixed Donald A. Lobo  
         
        17.
        CRM/Mailing/Form/Upload.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        18.
        drupal/modules/civicrm_engage/templates/CRM/Contact/Form/Edit/Demographics.tpl Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 10 minutes
        Remaining Estimate - 10 minutes
         
        19.
        drupal/modules/civicrm_engage/templates/CRM/Contact/Page/View/Demographics.tpl Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 20 minutes
        Remaining Estimate - 20 minutes
         
        20.
        drupal/modules/views/civicrm.views.inc Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 20 minutes
        Remaining Estimate - 20 minutes
         
        21.
        Various template file fixes Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 2 hours
        Remaining Estimate - 2 hours
         
        22.
        Remove assumption that all activities are assigned to a valid campaign. Trivial Done/Fixed Rajan P Mayekar  
         
        23.
        Some of the $row elements in templates/CRM/Activity/Selector/Activity.tpl are lacking an 'id' element. Minor Done/Fixed Donald A. Lobo  
         
        24.
        Undefined index: participant_role_id inCRM/Event/Selector/Search.php on line 388 Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 15 minutes
        Remaining Estimate - 15 minutes
         
        25.
        Undefined property: owner_membership_id in CRM/Member/Page/Tab.php CRM/Member/Page/Tab.php Trivial Done/Fixed Donald A. Lobo

        0%

        Original Estimate - 5 minutes
        Remaining Estimate - 5 minutes
         
        26.
        Patches forward-ported to the trunk.d7 branch Minor Done/Fixed Donald A. Lobo  
         
        27.
        Ensure that sort key is set for all getColumnHeaders() functions. Minor Done/Fixed Donald A. Lobo  
         
        28.
        Ensure that contact_id and display_name get assigned before calling templates that require them. Trivial Done/Fixed Rajan P Mayekar  
         
        29.
        Ensure that as_select gets assigned before calling template that requires it. Trivial Done/Fixed Rajan P Mayekar  
         
        30.
        Ensure that hookLinks variable gets assigned in CRM/Contact/Page/View.php Trivial Done/Fixed Donald A. Lobo  
         
        31.
        Assign required template variable noFieldSet before calling templates/CRM/Activity/Selector/Activity.tpl Trivial Done/Fixed Rajan P Mayekar  
         
        32.
        Always set activity_status_id even if empty Trivial Done/Fixed Rajan P Mayekar  
         
        33.
        Ensure that subject gets set in CRM/Mailing/Form/Browse.php Trivial Done/Fixed Rajan P Mayekar  
         
        34.
        Ensure activity-related template variables get set, even if empty. Trivial Done/Fixed Rajan P Mayekar  
         
        35.
        Allow templates/CRM/Case/Form/ActivityToCase.tpl to tolerate an unassigned buildCaseActivityForm or fulltext variable. Trivial Done/Fixed Rajan P Mayekar  
         
        36.
        Allow templates/CRM/Contact/Form/ActionsButton.tpl to tolerate an unassigned userRecordUrl variable. Trivial Done/Fixed Rajan P Mayekar  
         
        37.
        Ensure that imageURL gets assigned, even if blank. Trivial Done/Fixed Rajan P Mayekar  
         
        38.
        Either ensure that isDuplicate template variable always gets assigned, or modify templates to tolerate an unassigned isDuplicate variable. Trivial Done/Fixed Donald A. Lobo  
         
        39.
        Tolerate unassigned county_id array key in templates/CRM/Contact/Form/Edit/Address/county.tpl file. Trivial Done/Fixed Rajan P Mayekar  
         
        40.
        Standardize handling of geocoding variables Trivial Done/Fixed Rajan P Mayekar  
         
        41.
        Ensure that shared_address_display is assigned and checked. Trivial Done/Fixed Rajan P Mayekar  
         
        42.
        Tolerate various unassigned variables in templates/CRM/Contact/Form/Edit/CommunicationsPreferences.tpl Trivial Done/Fixed Rajan P Mayekar  
         
        43.
        Consistently set shared_address_display and use_shared_address variables. Trivial Done/Fixed Rajan P Mayekar  
         
        44.
        Ensure that employer-related variables get assigned, even if blank. Trivial Done/Fixed Rajan P Mayekar  
         
        45.
        Ensure that multiClient gets properly converted to a javascript-compatible Boolean in templates/CRM/Contact/Form/NewContact.tpl Trivial Done/Fixed Rajan P Mayekar  
         
        46.
        Ensure that context gets assigned consistently. Trivial Done/Fixed Rajan P Mayekar  
         
        47.
        Improve handling of saved search template variables. Trivial Done/Fixed Rajan P Mayekar  
         

          Activity

            People

            • Assignee:
              rajan Rajan P Mayekar
              Reporter:
              pillarsdotnet Bob Vincent
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days, 55 minutes
                2d 55m
                Remaining:
                Remaining Estimate - 2 days, 55 minutes
                2d 55m
                Logged:
                Time Spent - Not Specified
                Not Specified