Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-7567

ContributionProcessor.php maps "source" field differently for PayPal and Google Checkout

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.3.5
    • Fix Version/s: 3.4.alpha
    • Component/s: CiviContribute
    • Labels:
      None

      Description

      ContributionProcessor.php maps Google Checkout's item-name field to CiviCRM's note field. A more appropriate mapping would be:

      'item-name' => 'source'
      'item-description' => 'note'

      Changing it in this way seems more intuitive to me, and furthermore makes it consistent with the existing mapping for PayPal, which maps the item name (l_name0) to source:

      'l_name0' => 'source'

      Trival patch:

      http://code.creativecommons.org/viewgit/civicrm.git/commit/?h=cc_production_3.3.5&id=ae2ad8431a3914579486dd797d10bfa19128d7c3

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              nkinkade Nathan Kinkade
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: