Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8435

Pre hook inconstencies affecting RULES

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.4.4, 4.0.4
    • Fix Version/s: 4.4.0
    • Labels:
      None

      Description

      Rules needs more information to act on a delete than exists when POST hook called.

      I can move it to the PRE hook (http://pastebin.com/NJtn71yJ) but PRE hooks also need to be edited to pass more information to the hook than currently occurs.

      However, the discussion is then that not all pre hooks have the object loaded when delete is called

      • In contact and event , relationship, grant it is loaded (either before or shortly after the PRE hook) but not passed in the PRE hook
      • for group & participant, contribution, pcp, pledge it isn't loaded
      • for tag & membership_payment is is passed to the hook

      So, do we try to be consistent & pass it out for all? Pass it out for none? Or do we fix those that have it loaded to pass it out & expect devs to test for it?

      Also, note it needs to be an array - what is the syntax for converting to array?

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: