Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8530

poping up Activity dahslet raises a javascript error in french

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.0.4
    • Fix Version/s: 3.4.6, 4.0.6
    • Component/s: None
    • Labels:
      None

      Description

      When you have the activity dashlet on your dashboard. You open a popup when you click on the zoom icon.
      At this moment, with the french translation, an error is raised.

      This is due to a not generalized way of handling localization.
      In the file templates/CRM/Activity/Selector/Selector.tpl, we find :
      """
      ZeroRecordText +=

      {/literal} {ts}

      ' for Activity Type = "'

      {/ts} {literal}

      """
      Two errors occured in this string :

      • First the position of the ' which is inside the translated string.
      • Second, there is no escape="js" provided.

      A quick solution is given in the attached patch.

      Important note : the two elements 'First' and 'Second' described here above are the source of plenty of bugs when you are using localization (for example the one with the Dashboard configuration).

        Attachments

          Activity

            People

            • Assignee:
              kurund Kurund Jalmi
              Reporter:
              tonthon tonthon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Remaining Estimate - 30 minutes
                30m
                Logged:
                Time Spent - Not Specified
                Not Specified