Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8651

Ensure unique radio button IDs on Advanced Search

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.4.4, 3.4.5, 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5
    • Fix Version/s: 4.1.0
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      Currently clicking the 'Created By' label (next to radio button) in Advanced Search Activities pane actually CHECKS the 'CMS User' radio button in the top pane - because they're both assigned the same ID (CIVICRM_QFID_1_2).

      In order to fix this (and other similar cases) we need the ability to pass in a counter 'start' value which will replace the currently hard-code value of 1 for idTextStr in packages/HTML/QuickForm/radio.php HTML_QuickForm_radio( )

      We'll move the idTextStr to class variable and then allow a form to modify it. In this case modify addRadio for activity_role in CRM/Activity/BAO/Query.php buildSearchForm to provide a unique counter starting integer.

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: