Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-8810

improve rules send email action FROM field

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.4.5, 4.0.5
    • Fix Version/s: 3.4.6, 4.0.6
    • Labels:
      None

      Description

      the 'send email' action in the drupal rules implementation has some flaws with how the FROM email address is handled.

      1) the form retrieves the site's default FROM address to populate the default FROM field value. you can overwrite and save, and it works fine. but when you edit the form, it reverts to the default value, because it lacks conditions to see if a value is already set.

      2) setting the FROM value to the default site value should also take place in the action itself – not just in the action form – if no value is set. currently, it's possible to leave an empty value in the form field, which results in SMTP errors when the rule action is triggered from the interface.

      the attached patch addresses both issues.

        Attachments

          Activity

            People

            • Assignee:
              lobo Donald A. Lobo
              Reporter:
              lcdweb Brian Shaughnessy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: