Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-9922

Change civicrm_batch.type_id to civicrm_batch.mode_id in trunk.civiaccounts

    Details

    • Type: Task
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.3.0
    • Component/s: Accounting Integration
    • Labels:
      None

      Description

      As part of integrated trunk.civiaccounts work on batches with MIH on batches, rename the batch_type_id field in trunk.civiaccounts to to mode_id, and move it from being a field of civicrm_financial_batch to being a field of civicrm_batch.

      Remove field from xml/schema/Financial/FinancialBatch.xml.

      The following is minimal set of references as a starting point - there will be more where batch and type_id are not on the same line.
      $ grep -r -n batch ./* | grep -v '.svn' | grep type_id
      ./CRM/Batch/Form/Entry.php:81: $this->_profileId = CRM_Core_BAO_Batch::getProfileId( $this->_batchInfo['type_id'] );
      ./CRM/Core/DAO/Batch.php:148: public $batch_type_id;
      ./CRM/Core/DAO/Batch.php:242: 'batch_type_id' => array(
      ./CRM/Core/DAO/Batch.php:243: 'name' => 'batch_type_id',
      ./CRM/Financial/Form/FinancialBatch.php:153: 'batch_type_id',
      ./CRM/Financial/Form/FinancialBatch.php:250: $params['batch_type_id'] = CRM_Utils_Array::key( 'Manual batch', $batchType );
      ./CRM/Financial/Form/Search/Custom/BatchSearch.php:120: 'batch_type_id',
      ./CRM/Financial/Form/Search/Custom/BatchSearch.php:150: $form->assign( 'elements', array( 'name', 'sort_name', 'batch_type_id', 'close_date', 'open_date', 'payment_instrument_id', 'manual_number_trans', 'manual_total', ) );
      ./CRM/Financial/Form/Search/Custom/BatchSearch.php:295:LEFT JOIN `civicrm_option_value` as covt ON covt.`value` = cb.`batch_type_id`
      ./CRM/Financial/Form/Search/Custom/BatchSearch.php:320: if( CRM_Utils_Array::value('batch_type_id', $this->_formValues ) )
      ./CRM/Financial/Form/Search/Custom/BatchSearch.php:321: $clauses[] = "( cb.batch_type_id LIKE '{$this->_formValues['batch_type_id']}' )";
      ./sql/civicrm.mysql:1950: `batch_type_id` int unsigned NOT NULL COMMENT 'fk to Batch Type options in civicrm_option_values'
      ./templates/CRM/Batch/Form/Batch.tpl:41: <tr class="crm-batch-form-block-type_id">
      ./templates/CRM/Batch/Page/Batch.tpl:47: <td class="crm-batch-type">{$row.type_id}</td>
      ./templates/CRM/Financial/Form/FinancialBatch.tpl:74: <td class="label">{$form.batch_type_id.label}</td>
      ./templates/CRM/Financial/Form/FinancialBatch.tpl:75: <td class="html-adjust">{$form.batch_type_id.html}</td>

        Attachments

          Activity

            People

            • Assignee:
              pradeep.nayak Pradeep Nayak
              Reporter:
              joemurray Joe Murray
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4 hours, 30 minutes
                4h 30m
                Remaining:
                Remaining Estimate - 4 hours, 30 minutes
                4h 30m
                Logged:
                Time Spent - Not Specified
                Not Specified