CRM-9975 packages/HTTP/Request.php is old, should be updated

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Incomplete
          • Affects Version/s: 4.1.1
          • Fix Version/s: Unscheduled
          • Component/s: None
          • Labels:
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            Developer Doc
          • Funding Source:
            Needs Funding

            Description

            The PEAR HTTP_Request object is used to make HTTP requests in some places in CiviCRM, but it has been superseded (but not quite deprecated) by HTTP_Request2:
            http://pear.php.net/package/HTTP_Request

            It's only used in a couple places:

            ./tools/extensions/org.civicrm.payment.googlecheckout/GoogleCheckout.php
            ./CRM/Core/Payment/Google.php
            ./CRM/Utils/System.php
            ./CRM/Utils/Address/USPS.php
            ./CRM/Utils/Sunlight.php
            ./CRM/Utils/Geocode/Google.php

            We can replace HTTP_Request with HTTP_Request2 and then update all the code that uses it, or we can replace it all with curl instead.

            Should Extension maintainers be notified when package is removed??

              Attachments

                Issue Links

                is supplemented by

                Bug - A problem which impairs or prevents the functions of the product. CRM-19784 Yahoo Placefinder service appears to have EOL'ed

                • Minor - Minor loss of function, or other problem where easy workaround is present.
                • Done/Fixed

                  Activity

                  [CRM-9975] packages/HTTP/Request.php is old, should be updated
                  Donald A. Lobo added a comment -

                  hey micah:

                  we spoke about this during the sprint and i thought we decided you were going to look at HTTP_Request2 and decide whether we should continue using it or switch to curl.

                  Wanna add this to your plate?

                  Mathieu Lutfy added a comment -

                  Stumbled on this issue randomly, and for what it's worth, 4.6/4.7 has: CRM/Utils/HttpClient.php which is a wrapper around curl.

                  • googlecheckout extension has been removed
                  • sunlight code has been removed

                  CRM/Utils/System.php -> has a function called getServerResponse(), which is rather redundant with CRM_Utils_HttpClient. We should probably just make it call that function. Only the Dashboard BAO seems to use this function.
                  CRM/Utils/Geocode/Yahoo.php
                  CRM/Utils/Geocode/Google.php
                  CRM/Utils/Address/USPS.php

                  Coleman Watts added a comment -

                  I've removed CRM_Utils_System::getServerResponse() as part of CRM-17663.

                  John K. added a comment -

                  That just leaves:

                  CRM/Utils/Geocode/Yahoo.php
                  CRM/Utils/Geocode/Google.php
                  CRM/Utils/Address/USPS.php

                  Coleman Watts added a comment - - edited

                  The Yahoo code will be addressed by Frank Gómez in CRM-19784

                  Eileen McNaughton added a comment -

                  closing due to age & neglect - please open a new one against current version if you wish to commit resources

                    People

                    • Assignee:
                      Micah Lee
                      Reporter:
                      Micah Lee

                      Dates

                      • Created:
                        Updated:
                        Resolved: