CRM-9980 Group name should be translatable in multilingual installation

Should work by doing 2 things :

• add the column in CRM/Core/I18n/SchemaStructure.php
• add a database upgrade in CRM/Upgrade/Incremental/sql/4.2.alpha1.mysql.tpl (use CRM/Upgrade/Incremental/sql/3.0.beta4.mysql.tpl as an example)

Also, we need to change CRM/Contact/BAO/Group.php to use query with CRM_Core_DAO::executeQuery instead of using pear core functions (whereAdd, selectAdd, fetch) which doesn't allow to rewriteSql for multilingual.

Seems to be more complicated than i thought. There is a pseudo constant allGroups based on group table. Also group can be used for permissions and mailing lists so maybe a few different places to look at.

After all, there is not much to change and it seems to work well. I should write some tests for this.

Commited to trunk

I forgot to make upgrade patch

I need to do some more test.
I have this error when i activate multilingual :
Database Error Code: Key column 'title_en_US' doesn't exist in table, 1072
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)

[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => CREATE UNIQUE INDEX UI_title_en_US ON civicrm_group (title_en_US) [nativecode=1072 ** Key column 'title_en_US' doesn't exist in table]
[type] => DB_Error
[user_info] => CREATE UNIQUE INDEX UI_title_en_US ON civicrm_group (title_en_US) [nativecode=1072 ** Key column 'title_en_US' doesn't exist in table]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="CREATE UNIQUE INDEX UI_title_en_US ON civicrm_group (title_en_US) [nativecode=1072 ** Key column 'title_en_US' doesn't exist in table]"]
)

Fixed. The bug was more generic, in some cases indexes where create before the column where added.