Details
-
Type:
Extension Review Request
-
Status: In Progress
-
Priority:
Major
-
Resolution: Unresolved
-
Labels:None
Description
Extension: https://civicrm.org/extensions/flexmailer
Github: https://github.com/civicrm/org.civicrm.flexmailer/
This is a dependency for the latest Mosaico builds.
Notes from review in progress against version 0.2-alpha2.
| Category | Criterion | Required for contributed extensions? |
Required for official extensions? |
Finding |
|---|---|---|---|---|
| Admin | Code is licensed under AGPLv3+, GPLv2+, LGPLv2+, MIT/X11, or BSD-2c | Required | Required | AGPL-3.0 |
| Admin | Code is published on github.com | Required | Required | Yes |
| Admin | Extension name uses "org.civicrm.*" namespace | No | Suggested | Yes |
| Admin | Bus factor >= 2 | No | Suggested | No. Totten is the only committer. |
| Admin | Access to project is granted to infra team | No | Suggested | Yes |
| Admin | Release schedule is aligned with core | No | Suggested | Unknown |
| Coding | All code complies with civicrm-core style guidelines | No | Required | Not evaluated |
| Coding | Automated tests execute within 3 minutes (or less) | No | Suggested | Not evaluated |
| Coding | All dependencies are at similar stage (Ex: A stable project should not depend on an experimental project) | No | Required | No stated dependencies except for core version |
| Coding | All strings are wrapped in ts() | Suggested | Required | |
| Coding | The project does not override PHP, TPL, JS, or SQL from civicrm-core | Required | Required | Passes |
| Coding | The project does not conflict with other official projects | Suggested | Suggested | Not evaluated |
| Distribution | The project is packaged as a CiviCRM Extension, Drupal Module, Backdrop Module, Joomla Extension, or WordPress plugin | Required | Required | Yes |
| Distribution | The project has a stable version (1.0+; not alpha or beta) | Required | Required | No |
| Distribution | A demo site is provided | Suggested | Suggested | Not evaluated |
| QA | The project declares, on the in-app extension management screen, the nature of any changes it makes to existing data or functionality. | Required | Required | Yes |
| QA | The project functions in all CMS's (for CiviCRM Extension) | Suggested | Suggested | Not evaluated |
| QA | An automated test suite is included | Suggested | Required | Yes |
| QA | Project is periodically re-validated with newer versions of CiviCRM and compatibility updates are published | No | Required | Not evaluated; still in early stages of development. |
| QA | All patches are subjected to peer review | No | Suggested | No |
| QA | All patches are subjected automated tests | No | Required | Not evaluated |
| Support | Documentation is published | Suggested | Required | Yes. Developer doc is available in README.md. As this is primarily a dev util, that's probably appropriate. |
| Support | Issues are tracked in an open, public issue management system | Suggested | Required | Yes |