EXT-44 https://civicrm.org/extensions/olark-chat

Hi Joe Murray. I've started the review for this extension. I've added a support ticket here though (https://github.com/JMAConsulting/biz.jmaconsulting.olarkchat/issues/12) as I don't see the extension working as I thought it would.

Looking forward to your response there, but in the mean time, I'm continuing with the more technical aspects of the review.

Extension review includes evaluation of a specific set of requirements. I'm documenting my findings for those requirements here: https://docs.google.com/document/d/1tyses6EMXOnhT5rmK3ZQrmvquAf-kDqosNxmIN-vxFM/edit?usp=sharing

Hi Joe,

This looks great and needs just one required change to pass the review:

Requirement: “The project declares, on the in-app extension management screen, the nature of any changes it makes to existing data or functionality.”

Evaluation: The extension creates an activity type “Chat Activity” and an option group “Olark Secret” with option value “Secret Code”. Please mention these on the in-app extension management screen.

I also recommend running civilint and adjusting code to fit CiviCRM coding standards. This isn't a requirement, but because new developers often learn by reviewing existing code, I encourage extension authors to adhere to CiviCRM coding standards as much as possible. I'm attaching here the civilint output for version 1.3 of this extension.

I'll assign this to you for completion of that one required change. Please assign back to me when that's done, and I'll take it from there.

Thanks for sharing your extension with the community!

Hi Allen Shaw

I have fixed the style issues and also updated the extension's description as

Is there anything else need to be fixed?

Thanks!

Hi Monish. These changes look great.

Please create a new release tag, and assign this back to me when the new release is published, then I can mark for automated distribution.

Thanks!

• Allen

Hi Allen Shaw

I have published new tag 1.4

Thanks