HR-111 On Removal of CiviHR modules menu item "Directory" not automatically removed

          Details

          • Type: Sub-task
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Won't Do
          • Affects Version/s: HR-1.0
          • Fix Version/s: None
          • Component/s: None
          • Labels:

            Description

            On wordpress 4.4 civicrm, uninstalling civiHR uninstall does not auto remove 'Directory' from menu and requires a user operation.

              Attachments

                Activity

                [HR-111] On Removal of CiviHR modules menu item "Directory" not automatically removed
                Tim Otten added a comment -

                Note that hrstaffdir_civicrm_install() inserts the link but nothing removes the link. Could uninstall the link via hrstaffdir_civicrm_uninstall(). (Although strictly speaking... it would be better to use hook_enable/hook_disable instead of hook_install/hook_uninstall.)

                However, best approach might be to use hook_civicrm_navigationMenu and the helper function _hrstaffdir_civix_insert_navigation_menu().

                Tim Otten added a comment -

                PR was merged – https://github.com/civicrm/civihr/pull/147

                  People

                  • Assignee:
                    Deepak Srivastava
                    Reporter:
                    Dan Pastuf

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - 1 hour, 30 minutes Original Estimate - 1 hour, 30 minutes
                      1h 30m
                      Remaining:
                      Remaining Estimate - 0 minutes
                      0m
                      Logged:
                      Time Spent - 4 hours, 20 minutes
                      4h 20m