Uploaded image for project: 'CiviVolunteer'
  1. CiviVolunteer
  2. VOL-92

Refactor form handling for contact search to improve extensibility

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Labels:
      None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None

      Description

      As written, the code[1] assumes that Group is the only core field that will be processed by the form handler.

      We might consider putting our core fields into a separate array rather than glomming them onto the custom fields[2] to more explicitly differentiate between core and custom fields.

      Links:
      [1] https://github.com/civicrm/org.civicrm.volunteer/blob/4973e686b448d9d4abee3ba9af512df2e87f6a54/js/apps/search/search_views.js#L102
      [2] https://github.com/civicrm/org.civicrm.volunteer/blob/4973e686b448d9d4abee3ba9af512df2e87f6a54/js/apps/search/search_controller.js#L23-L26]

        Attachments

          Activity

            People

            • Assignee:
              pittstains Frank J. Gómez
              Reporter:
              pittstains Frank J. Gómez
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: