CRM-10152 Contact API v3: Return duplicate IDs in Create

I think u made some changes to this and hence assigning to you. Can you please ensure that we dont break import with these changes and/or fix import as needed

Import doesn't use the API (It did share some functions with it but these should all have been divorced from the api functions now to prevent api changes affecting the import).

I think we are going to look @ error codes in 4.3 - so unless you have time to write a test (that uses the api -ie. civicrm_api() - not calling the function directly) I'm going to push this to 4.3

NB- I am pretty sure this aspect of the code has never worked in api v3 - as the calling v3 function doesn't pass in the relevant param!

Hi Xavier - can see on orig forum you told the guy to assign to you

This was an api v2 feature - not sure if it belongs in v3 or not - you decide - I think it was there to support import.

But there is no unit test with it

Hi,

so on 4.3, the function throw errors, that's good.

Don't think there is yet the option to give extra params to the exception, investigating it

@Paul B: when you make a patch, can you do it from the root of your civicrm install? It's easier for the readers to be sure which file(s) you patched.

@PaulB, can you confirm it works for you?

+ throw new API_Exception("Found matching contacts: ". implode(',',$ids),"duplicate",array("ids"=>$ids));

test on is_error=1 && error_code="duplicate" ids contains the ids you could use it to get the duplicate details...

X+

with correct version 4.3