Details

    • Type: Sub-task
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.2.0
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          [CRM-10664] Inline edit improvements
          Coleman Watts added a comment -
          • Deleted js code that dealt with hover effects, converted to pure css
          • Moved most js out of template files and into jquery.crmeditable.js
          • Combined redundant code blocks into a single fn
          • Made entire edit region clickable
          • Added concept of 'dependent-fields' which can automatically reload other blocks from the server (when saving one region that could potentially change values in others) - no more duplicating logic on the client side
          • Fixed ajax calls to use async
          • Cancel button no longer hits the server
          • Fixed use of addCiviOverlay to actually show the overlay while loading
          • CSS improvements: help text no longer displaces elements or causes size-change jumpyness; dashed border darkens and persists (no hover effect) during editing
          • Changed form snippet id 'crm-container-snippet' to a class (since we may have more than one per page)
          • Abstracted the "add new" functionality from address, to potentially work with other objects
          • Fixed up $.crmURL() and added init to every page load - so crmURL can now be called from client-side
          • Removed hard-coded assumptions about snippet class name containing 'CRM/Contact/Page/Inline' - Hopefully this paves the way for adding inline edits to other objects/contexts
          Coleman Watts added a comment -

          In conversation with Kurund, tweaking the animate effect.

            People

            • Assignee:
              Coleman Watts
              Reporter:
              Coleman Watts

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 2 hours
                2d 2h