CRM-10791 Greetings aren't required on contact/edit form but should be

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Cannot Reproduce
    • Affects Version/s: 4.2.0
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      When you click on a contact's greeting to edit, it reveals a select list which allows you to choose nothing. But doing so produces the not-so-good result of clearing the greeting type but not clearing the cached greeting from the contact record.
      Quick fix - remove the empty option from the select menu.

        Attachments

          Activity

          [CRM-10791] Greetings aren't required on contact/edit form but should be
          Kurund Jalmi added a comment -
          • Currently you cannot add a contact of type Organization
          David Greenberg added a comment -

          I've reverted this change since it broke the Add Organization form.

          After reverting I ran several tests to try and replicate the reported problem - "clearing greeting type not clearing cached greeting" (e.g. civicrm_contact.*_greeting_display column). I was not able to replicate this problem.

          My tests:

          • Save new Individual contact with default greeting types set.
          • Edit the contact and change greeting types to select (null value)
          • Check *_greeting_display column values in DB - they are returned to NULL as expected.
          • Repeat - using inline edit form for the update (same result)

          If there's a different sequence which causes the stale cache - we should look at a fix in 4.3.

          Coleman Watts added a comment -

          Now seems to be working fine.
          False alarm.

            People

            • Assignee:
              Coleman Watts
              Reporter:
              Coleman Watts

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 20 minutes
                20m