CRM-10905 inline edit fields layout issues

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.2.1
    • Fix Version/s: 4.2.3
    • Component/s: None
    • Labels:

      Description

      there are some issues with the inline edit layout fields. if a label runs to two lines, the field row below it may bump to the right of the label because the floats are cleared between each row.

      I think we should be wrapping each row in a div with crm-section class, as we do everywhere else. currently the fields are just presented with div-label, div-content, alternating, which is what causes the problem.

      see the comm details custom set here for an example:
      http://drupal.demo.civicrm.org/civicrm/contact/view?reset=1&cid=102

        Attachments

          Activity

          [CRM-10905] inline edit fields layout issues
          Kurund Jalmi added a comment -

          This is already fixed in 4.3, can you please check on sandbox ?

          Brian Shaughnessy added a comment -

          no – the problem still exists on the sandbox. see constituent data block for this contact: http://sandbox.drupal.civicrm.org/civicrm/contact/view?reset=1&cid=2
          and looking at the html structure, the label+content divs are not wrapped in a containing div (which is really the only was we're going to make sure this is fixed)

          David Greenberg added a comment -

          Brian - most helpful if you can attach one or more screen shots to show what you're seeing.

          Brian Shaughnessy added a comment -

          sure – see attached. the section in green is a separate field which should be aligned left with the other fields. it gets bumped up because the .label class floats left and there's no float clear between rows to force it down.

          Coleman Watts added a comment -

          This seems to be a duplicate of CRM-10707, which has been fixed for 4.3

          Brian Shaughnessy added a comment -

          confirmed – this is addressed via another ticket for 4.3

            People

            • Assignee:
              Kurund Jalmi
              Reporter:
              Brian Shaughnessy

              Dates

              • Created:
                Updated:
                Resolved: