Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.2.0
-
Fix Version/s: 4.2.3
-
Component/s: None
-
Labels:None
Description
the sql for v4.2.a1 inserts an activity type "Reminder Sent"
but we already have an activity type with that name inserted with 3.4.3
I'm unclear if there is a meaningful distinction between them. And if so, we should alter the labels to distinguish them, as they both appear in activity searches, etc.
Attachments
Activity
Dave, FWIW – I believe the second version of it was inserted and flagged reserved. So I transferred activities from the old to the new and removed the old (I kept the reserved version).
Can you do a quick code review. I've tested the sequence of queries and they function as expected when run via mySql (replacing variables).
Also, noticed this that this "task" seems to be called in two different upgrade functions (4_2_2 and 4_2_alpha1):
task_4_2_alpha1_runSql
Not quite sure what it does, so not sure if it needs to be called in 4_2_3 as well ??
Added a call to task_4_2_alpha1_runSql function inside 4_2_3 in 'FourTwo.php' file as the queries in '4.2.3.mysql' script file were not running (added 4.2.3.mysql file for issue : CRM-10969).
Just to clarify further - When there is a php upgrade method, sql tpl files are not run/called and are supposed to be called by php method itself. So method has to make a call like $upgrade->processSQL().
And this processSQL in FourTwo.php file, is being called by task_4_2_alpha1_runSql. Its not mandatory to call task_4_2_alpha1_runSql, but since its already there and has been used in other earlier 4.2 php upgrade functions, its fine.
I think whats misleading here is the name of the function - task_4_2_alpha1_runSql should have been say task_4_2_runSql or a local helper function.
This is definitely a duplicate, added my mistake in the upgrade. I won't be present in sites newly installed after 4.2 alpha 1. Will need to check to dupes and delete the second one.