CRM-11359 Yahoo geocoder throws ugly error to user when you exceed your limits

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.2.6
          • Fix Version/s: 4.2.7
          • Component/s: Core CiviCRM
          • Labels:
            None

            Description

            When you have exceeded your limits to Yahoo, Yahoo sends a poorly formated xml comment that causes php to throw an error:

            Warning: simplexml_load_string(): Entity: line 9: parser error : Comment not terminated inCRM_Utils_Geocode_Yahoo::format() (line 127 of /var/aegir/platforms/alberto-ourpowerbase-d7-c4.2/sites/all/modules/civicrm/CRM/Utils/Geocode/Yahoo.php).

            I think we should suppress that error by placing an @ in front of the function call. CiviCRM will still catch and log the error, but from the user perspective we silently fail.

              Attachments

                Activity

                [CRM-11359] Yahoo geocoder throws ugly error to user when you exceed your limits
                Jamie McClelland added a comment -

                See also somewhat related forum post: http://forum.civicrm.org/index.php/topic,26989.0.html

                Jamie McClelland added a comment -

                the @ sign has been added to the function to suppress errors.

                  People

                  • Assignee:
                    Jamie McClelland
                    Reporter:
                    Jamie McClelland

                    Dates

                    • Created:
                      Updated:
                      Resolved: