Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-11456

Online contribution thank-you page notices - code pointing to non-existent property in FinancialType table

    Details

      Description

      Thank-you page after submitting an online contribution (using Dummy payment processor) has the following notices:

      1. The notice below seems to be an actual bug. I think code on line 82 is wrong since FinancialType does NOT have accounting_code property.

      Notice: Undefined property: CRM_Financial_DAO_FinancialType::$accounting_code in CRM_Contribute_BAO_Contribution_Utils::processConfirm() (line 82 of /Users/dgg/svn/crm_v4.3/CRM/Contribute/BAO/Contribution/Utils.php).

      2. These notices I think can be fixed using CRM_Utils_Array (since this is NOT a partial payment scenario). Please also fix formatting for the new code in this section (spacing / indenting is wrong as is the use of if without curly braces lines 237-240)
      .
      Notice: Undefined index: initial_amount in CRM_Contribute_BAO_Contribution_Utils::processConfirm() (line 233 of /Users/dgg/svn/crm_v4.3/CRM/Contribute/BAO/Contribution/Utils.php).
      Notice: Undefined index: initial_amount in CRM_Contribute_BAO_Contribution_Utils::processConfirm() (line 241 of /Users/dgg/svn/crm_v4.3/CRM/Contribute/BAO/Contribution/Utils.php)

        Attachments

          Activity

            People

            • Assignee:
              kurund Kurund Jalmi
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: