Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Minor
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.3.0
-
Fix Version/s: 4.3.0
-
Component/s: Accounting Integration
-
Labels:None
Description
Just tested a 4.2 -> 4.3 upgrade w/ mostly just sample data and sample meta-data. However I disabled the default 'Donation' contribution type and added a few others. Things worked properly in terms of creating entity_financial_account linkages for the 'non-default' financial types.
HOWEVER, I noticed that my remaining default types (Event Fee, etc.) had 4 linked accounts - including the Payment Processor Account (Asset account). The non-default financial types did NOT have this account linkage. I'm pretty sure that we don't want this linkage for any financial types by default since we will select the Asset account based on the payment instrument or payment processor used.
I scanned 4.3.alpha1.mysql.tpl to see where this was happening, but couldn't find the spot 
It was not because of upgrade. The financial type account listing was wrong. The entity_table = 'civicrm_financial_type' filter was missing to retrieve all the financial type account for a financial type. So it was also retrieving financial account of the payment processor add/or payment instrument.
Fixed and checked at r44728.