CRM-11687 Remove option-level financial types from configure event-Fees; configure contribution page:Amounts, Membership

    Details

    • Type: Sub-task
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.3.0
    • Component/s: Accounting Integration
    • Labels:
      None

      Description

      On Configure Event, Fee tab:

      1. Add a Financial Type field between Fee Label and Price Set that will be used for quick config price set and discounted fees and for non-income accounts for complex price sets.

      2. Remove the Financial Type column from the Regular Fees section and the Discounted Fees section.

      3. When attempting to create a discount set with dates that overlap an existing one, the validation rule against this puts up an appropriate error message, but the form has the discount set added in the Discounted Fees table.

      On Configure Contribution Page:
      1. Remove financial type dropdowns from Fixed Amount options

      2. Put financial type dropdown back on Title tab

      3. Remove financial type dropdowns from Memberships tab - Membership type grid

      4. Test that we are doing the right thing in assigning financial type to contributions where membership is purchased in this quick config environment (should be same behavior is in 4.2)

      • contributions should retrieve financial type from the membership type purchased
      • for 'separate membership payment' flow, membership contribution uses membership type's FT, and additional contribution uses FT of contribution page

      NOTE: When reverting these changes, please make sure we do NOT revert the code which exposes financial type for Price Fields and Price Field Value options when using NON quick-config price sets.

        Attachments

          Activity

          [CRM-11687] Remove option-level financial types from configure event-Fees; configure contribution page:Amounts, Membership
          David Greenberg added a comment -

          Pradeep - please hold off on this until I resolve w/ Joe. I'm not convinced that allowing users to set financial type for each option in the Quick Config scenario makes any sense.

          Donald A. Lobo added a comment -

          Also note at this point in time, we should not be adding any new functionality, except for ones which all of us agree are super-essential

          Can we please ensure that all feature adds are now assigned to 4.4

          Joe Murray added a comment -

          dgg: I too thought we had agreed not to have financial type displayed on rows for fees. I knew you had gone over the events stuff a bunch so I didn't want to presume that decision had stood, and was just trying to smooth out what was there. Given your comment here I've changed the issue description. Please review and then assign to Pradeep.

            People

            • Assignee:
              David Greenberg
              Reporter:
              Joe Murray

              Dates

              • Created:
                Updated:
                Resolved: