CRM-11826 Move logic for creating a new payment processor from CRM_Admin_Form_PaymentProcessor::updatePaymentProcessor to BAO

    Details

    • Type: Sub-task
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.3.0
    • Component/s: Accounting Integration
    • Labels:
      None

      Description

      Unit tests are failing because they're calling CRM_Financial_BAO_PaymentProcessor::create and expecting it to create the entity_financial_account row when financial_account_id is passed in. However the logic for this is still in CRM_Admin_Form_PaymentProcessor::updatePaymentProcessor.

      Please move necessary logic from the form to the BAO, and have the form postProcess call the BAO. Then I can go in and fix the tests.

        Attachments

          Activity

          [CRM-11826] Move logic for creating a new payment processor from CRM_Admin_Form_PaymentProcessor::updatePaymentProcessor to BAO
          Pradeep Nayak added a comment -

          dint move the code from CRM_Admin_Form_PaymentProcessor::updatePaymentProcessor since in updatePaymentProcessor the BAO create method is not called, the Payment processor DAO object is created and saved directly.
          So added same logic in BAO create method if financial_account_id is NOT NULL

          checked at r45372.

            People

            • Assignee:
              David Greenberg
              Reporter:
              David Greenberg

              Dates

              • Created:
                Updated:
                Resolved: