CRM-12233 Online membership signup - contribution amounts field should not be required + various notices

Submited PR at 279.

Do i need to handle label changes for Membership amount to Membership?

UPDATE civicrm_price_field cpf
LEFT JOIN civicrm_price_set cps ON cps.id = cpf.price_set_id
SET cpf.label = 'Membership'
WHERE cps.is_quick_config =1 AND cpf.name = 'membership_amount';

Above query is to update Membership Amount label to Membership for quick config price sets. Not sure if upgrade query is needed

I think we should do that upgrade query since user can't fix it via UI. I've added it to beta5. https://github.com/civicrm/civicrm-core/pull/281

Looking much better. Remaining issues are:
1. Still getting notice on Confirm step when:
Contrib Amts Enabled=TRUE, Other Amounts=TRUE, Fixed Amounts=FALSE
Req Mem Signup TRUE, Separate Mem Pmt TRUE
User doesn't enter Addtional Contribution

Notice: Undefined index: 11 in CRM_Contribute_Form_Contribution_Confirm->preProcess() (line 166 of /Users/dgg/git/crm_v4.3/CRM/Contribute/Form/Contribution/Confirm.php).
(screenshot attached)

2. Additional Contribution field with fixed contribution options is missing 'No thank you' radio button for the 'Separate Membership Payments=FALSE scenario. This means user can't decide NOT to contribute once they've checked one of the radio button (screenshot 1). If I switch 'Separate Membership Payments=TRUE we provide the 'No thank you' option (and make the field required) (screenshot 2). Would be best if the form fields are the same for both modes here - but in any case we need to give folks 'No thank you' option for the first scenario.

3. Notice on Thank-you step for:
Contrib Amts Enabled=TRUE, Other Amounts=TRUE, Fixed Amounts=TRUE
Req Mem Signup TRUE, Separate Mem Pmt TRUE
... and user checks 'No thank you' for contribution amount (e.g. no 2nd contribution record to be created)
(screenshot attached)

Notice: Trying to get property of non-object in CRM_Member_BAO_Membership::postProcessMembership() (line 1251 of /Users/dgg/git/crm_v4.3/CRM/Member/BAO/Membership.php).

Hey Dave

For #2, for scenario
Contrib Amts Enabled=TRUE, Other Amounts=TRUE, Fixed Amounts=TRUE
Req Mem Signup FALSE, Separate Mem Pmt TRUE

If the user clicks on No thank you Membership and also No thank you Additional Amount. Then do i need to provide form rule to make Additional Contribution required when Membership is "No thank you"?

submiited PR at https://github.com/civicrm/civicrm-core/pull/294.

Changes not committed for http://issues.civicrm.org/jira/browse/CRM-12233?focusedCommentId=49574&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-49574

Yes - for scenario #2, either a membership must be selected OR a contribution amount entered/selected.

submitted PR = 304.

added form rule also.

Tested all case above except new form rule (PR=304 not merged yet). All looks good, except newly created online contrib page w/ membership block was still using 'Membership Amount' as label. Submitted fix at https://github.com/civicrm/civicrm-core/pull/311.

Form rule now ensures that EITHER a membership amount OR a contribution amount is entered / selected.