Details
-
Type: Bug
-
Status: Done/Fixed
-
Priority: Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.3.0
-
Fix Version/s: 4.3.1
-
Component/s: None
-
Labels:None
Description
We can't keep the tests at 100 % if we don't get them there. Currently failing
1) Payment Processor single value alter
reason, because payment processor copies in the values from payment_processor_type
Recommendation - remove from the test
Real Recommendation - don't duplicate class_name, billing_type in payment processor & payment_processor_type. If there is a reason for them to be duplicated then the automatic over-write shouldn't happen
2) Setting api - only id should be enough fails
reason because it is trying to get a domain that doesn't exist which according the api should be supported as the expectation is that this is an empty result not an error. However, in this case 'id' translates to domain_id & there is a hard error coded into the Domain BAO class (fatal)
Recommendation - remove the test
Real Recommendation - throw an exception rather than a fatal at the BAO layer
3) Relationship Update test failing
Reason, because we fixed the way 'id' versus relationship_id was being handled. Now that 'relationship_id' works the test is failing - but the test was only working because it wasn't actually doing an update before.
Recommendation - pull the test/ update it to just be a 'create' not an update.
Real recommendation - pull the test. Because I'm not sure the API should be restricting the ability to update an existing relationship to match another existing one (sounds like more checking that we need) & it wasn't being truly tested before as far as I can see
4) Entity tag doesn't follow id only conformance
Reason - non standard api because of ambiguity of meaning of 'id' - in this api it means tag id not entity_tag id
Recommendation - pull the test
Real Recommendation - create api v4 & put a standardised version of entity_tag in there
5) Grant test - TBC