CRM-12563 Mismatched <table> tags in MembershipRenewal.tpl

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.2
    • Fix Version/s: 4.3.4
    • Component/s: Core CiviCRM
    • Labels:

      Description

      Since I upgraded to 4.3.1 the page at civicrm/contact/view/membership broke (layout).

      I finally whittled this down to an extra CLOSING table tag in templates/CRM/Member/Form/MembershipRenewal.tpl. (If you count opening vs. closing you'll see 6 open tables and 7 close-tables.)

      Two fixes happen to work for me, however, I'm not sure which is actually the correct one.

      1) get rid of the closing table tag on line 183.
      2) get rid of the

      {else}

      and closing table tag on lines 209-210.

      I'm thinking #2 feels more correct to me, but as I don't understand the larger-scale ramifications this might have, I'd like someone else who knows more about this template to take a look.

        Attachments

          Activity

          [CRM-12563] Mismatched <table> tags in MembershipRenewal.tpl
          David Greenberg added a comment -

          Chris - can you clarify whether the mismatch happens in Renew Membership vs. Renew Membership - Credit Card.

          Chris Wells added a comment -

          Hi David - sorry for the delay – my wife went into labor about 90 minutes after I posted this issue!

          I can confirm that it is regular "renew" – it appears "renew - credit card" is fine (in the sense that I don't have the same rendering issues as I have on the regular renew page).

            People

            • Assignee:
              Kurund Jalmi
              Reporter:
              Chris Wells

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 1 hour
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified