Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-12804

version_compare in CRM_Utils_Form::doIncrementalUpgradeFinish() tests unset value

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.4
    • Fix Version/s: 4.3.5
    • Component/s: None
    • Labels:
      None

      Description

      CRM_Utils_Form::doIncrementalUpgradeFinish() does this -

      if (version_compare($currentVer, '4.1.alpha1') >= 0)

      { CRM_Core_BAO_Setting::updateSettingsFromMetaData(); }

      But it doesn't get $currentVer passed in from CRM_Utils_Form::buildQueue(), so this will only ever print a warning and skip the step.

      I'm unclear on whether the updateSettingsFromMetaData() step is required at all.

      Small change to buildQueue() can restore the passing in of this value.

        Attachments

          Activity

            People

            • Assignee:
              pratik.joshi Pratik Joshi
              Reporter:
              xurizaemon Chris Burgess
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: